Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-oracle-flashback: only validate and operate on enabled bindings #2013

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

mdibaiee
Copy link
Member

@mdibaiee mdibaiee commented Oct 3, 2024

Description:

  • Until now we were doing a full discovery for each Validate and Open call, but normally other connectors only operate on the requested bindings. Here I'm implementing the same logic so that we don't have to do a full discovery every time, instead we only validate tables that match bindings.
  • This originally came about because we have tasks which take so long to discover that their Validate request was timing out. Most of the time spent during the request was spent on getting the MAX_ROWID of tables. By reducing the number of tables that we query to only the enabled ones, we should be able to run Validates much faster.
  • Tested with integration tests and manually running a task with disabled bindings

Workflow steps:

(How does one use this feature, and how has it changed)

Documentation links affected:

(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)

Notes for reviewers:

(anything that might help someone review this PR)


This change is Reviewable

Copy link
Member

@williamhbaker williamhbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % comment about get_tables

@mdibaiee mdibaiee force-pushed the mahdi/flashback-validation-speed branch from 4fdf86d to e9e439c Compare October 3, 2024 14:19
@mdibaiee mdibaiee merged commit 5c263e1 into main Oct 3, 2024
69 of 75 checks passed
@mdibaiee mdibaiee deleted the mahdi/flashback-validation-speed branch October 3, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants